Ref #77388 - disallow passing BAD_ESCAPE_IS_LITERAL, esp by default #4429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this option is considered dangerous and unwanted
|
It probably makes more sense to target this at PHP 8. |
nikic
reviewed
Jul 17, 2019
| @@ -704,7 +695,6 @@ PHPAPI pcre_cache_entry* pcre_get_compiled_regex_cache(zend_string *regex) | |||
| case 'D': coptions |= PCRE2_DOLLAR_ENDONLY;break; | |||
| case 'S': /* Pass. */ break; | |||
| case 'U': coptions |= PCRE2_UNGREEDY; break; | |||
| case 'X': extra_coptions &= ~PCRE2_EXTRA_BAD_ESCAPE_IS_LITERAL; break; | |||
There was a problem hiding this comment.
I wonder if this should still allow the modifier but ignore it? Like for S.
There was a problem hiding this comment.
Right - that's not a bad idea.
|
while github allows changing the base - this only really works if I had made a feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this option is considered dangerous and unwanted by the author of pcre:
While this is a B/C change - it is more likely to expose (existing) problems that can quickly be fixed by fixing the regexp. There were no objections against removing it on php-internals