Remove build.mk usage #4437
Closed
Remove build.mk usage #4437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
force-pushed
the
patch-remove-make-from-buildconf
branch
from
e268842 to
b5624e9
Compare
First step when creating the `configure` script is currently using make. This is helpful when developing buildsystem to only rebuild `configure` and `main/php_config.h.in` files when one of the *.m4 or configure.ac file changes and saves the developer time a little. Realistically however, it is not needed that much considering the times of several seconds to fully rebuild the configure script and configuration header. The next step when running the `configure` script is much more time consuming so performance on buildconf level is a bit questionable and won't be noticed on today's systems. Additionally: - buildconf now removes cache and all targets and uses -f option on the first step i.e. autoconf. The autoheader does not need the -f option in this case.
petk
force-pushed
the
patch-remove-make-from-buildconf
branch
from
b5624e9 to
f733d23
Compare
|
So this now:
|
nikic
approved these changes
Jul 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first step when creating configure script is currently using make. This is helpful when developing build system to only rebuild
configureandphp_config.h.infiles when one of the *.m4 file changes.Realistically, it is not needed that much considering the time of several seconds to fully rebuild the configure script.
To better understand this:
time ./buildconf (with make) -> 4sectime ./buildconf (without make) -> 3secApproach shown in #4355 decreases time for another second approximately.
When downloading PHP release tarball
configureandphp_config.h.inare already included and scripts without using --force exits before reaching the files generation steps. The configure steps takes 10s up to a minute depending on options, so performance improvements and simplifications here are more or less only for core devs...Thanks.
Redaction
that drastically practical anyhow because build system developers mostly regenerate all files all the time...