Improve strpos and strstr function family implementation #4558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 18, 2019
|
The error message change is because |
Girgias
changed the title
nikic
reviewed
Aug 19, 2019
|
Could you please split the changes to the strrpos/strripos error handling / implementation into a separate PR? |
Girgias
force-pushed
the
improve-strpos-family-function
branch
from
09cdbfe to
a56a784
Compare
nikic
reviewed
Aug 26, 2019
nikic
reviewed
Aug 26, 2019
|
Test failures maybe due to being rebased before 0038db2 |
Girgias
force-pushed
the
improve-strpos-family-function
branch
from
7019f9c to
1953a7e
Compare
nikic
approved these changes
Aug 26, 2019
|
|
||
| Warning: stristr(): Empty needle in %s on line %d | ||
| bool(false) | ||
| string(11) "Hello World" |
There was a problem hiding this comment.
You can drop this file. These are no longer error conditions, and the result is already checked in stristr.phpt.
|
Merged in as 6d57848 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove empty needle as failure case, normalise implementations and error messages.
Removed test file for bug 63943 as it was covering if the correct warning message is displayed.
Split non 7-bit ASCII characters test into a separate variation test.