Fix opcache optimizer info for time_nanosleep+passthru #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can also return an array. See https://www.php.net/manual/en/function.time-nanosleep.php#refsect1-function.time-nanosleep-returnvalues > If the delay was interrupted by a signal, an associative array will be returned with the components: > > - seconds - number of seconds remaining in the delay > - nanoseconds - number of nanoseconds remaining in the delay Sending a SIGUSR1 to the below program would trigger this behavior. ``` pcntl_signal(\SIGUSR1, function ($signo, $signinfo) { echo "Handling a signal $signo\n"; }); echo "Sleeping for 100 seconds\n"; var_export(time_nanosleep(100, 0)); ``` The incomplete signature existed since c88ffa9. No phpt tests existed for time_nanosleep returning an array
Backported from a1a8d14 https://www.php.net/manual/en/function.passthru.php#refsect1-function.passthru-returnvalues `passthru()` is false with invalid args `passthru('command')` is null.
TysonAndre
changed the title
nikic
approved these changes
Aug 26, 2019
TysonAndre
added a commit
to TysonAndre/php-src
that referenced
this pull request
Sep 3, 2019
Fixes my earlier PR php#4617 If I remember correctly, The F0 macro is used for return values that are guaranteed to not be reference counted. The F1 macro is used for return values that may have up to 1 reference (i.e. MAY_BE_RC1). I didn't notice that time_nanosleep needed to be F1 since it could return an array, and that array is reference counted.
php-pulls
pushed a commit
that referenced
this pull request
Sep 3, 2019
Fixes my earlier PR #4617 If I remember correctly, The F0 macro is used for return values that are guaranteed to not be reference counted. The F1 macro is used for return values that may have up to 1 reference (i.e. MAY_BE_RC1). I didn't notice that time_nanosleep needed to be F1 since it could return an array, and that array is reference counted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported from d95c15e - PHP 7.1 was also affected but is only receiving security support
This can also return an array. See
https://www.php.net/manual/en/function.time-nanosleep.php#refsect1-function.time-nanosleep-returnvalues
Sending a SIGUSR1 to the below program would trigger this behavior.
The incomplete signature existed since c88ffa9.
No phpt tests existed for time_nanosleep returning an array
Also fix signature for passthru
Backported from a1a8d14
https://www.php.net/manual/en/function.passthru.php#refsect1-function.passthru-returnvalues
passthru()is false with invalid argspassthru('valid or invalid command')is null.