Skip to content

Request 64744 #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2014
Merged

Request 64744 #462

merged 1 commit into from
Jun 9, 2014

Conversation

bor0
Copy link
Contributor

@bor0 bor0 commented Sep 20, 2013

https://bugs.php.net/bug.php?id=64744

Show the type of the non-object for more descriptive errors

@nikic
Copy link
Member

nikic commented Sep 20, 2013

I would prefer to remove the "non-object" part altogether in this case:

Call to a member function bar() on a non-object (boolean)
Call to a member function bar() on a boolean
Call to a member function bar() on boolean

The latter avoids issues with a/an.

But in any case, the tests should include the actual error message rather than a %s placeholder there :)

@bor0
Bug 64744
bce1151 
Show the type of the non-object for more descriptive errors
@bor0
Copy link
Contributor Author

bor0 commented Sep 20, 2013

PR updated per suggestions.

@php-pulls php-pulls merged commit bce1151 into php:master Jun 9, 2014
@dunglas dunglas mentioned this pull request Sep 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bor0 @nikic @php-pulls