Convert soap functions arginfo to php stubs #4621
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 30, 2019
duncan3dc
force-pushed
the
convert-soap-arginfo
branch
from
68e1ff9 to
3ab8dc6
Compare
duncan3dc
force-pushed
the
convert-soap-arginfo
branch
from
3ab8dc6 to
85466cd
Compare
nikic
approved these changes
Sep 17, 2019
|
Thanks! Applied as 8326ef5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the value argument of
setCookie()should be nullable so I made that change too.I think I'm getting better at reading zpp now 🤞