add librt for opcache #4794
Closed
add librt for opcache #4794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
force-pushed
the
issue-librt
branch
from
76324ea
to
78247eb
Compare
|
FYI On Fedora 29 On Fedora 31 |
remicollet
force-pushed
the
issue-librt
branch
from
78247eb
to
8c92b5c
Compare
|
During configure, -lrt is there (in For robustness, I also add |
dstogov
reviewed
Oct 8, 2019
ext/opcache/config.m4
Outdated
| @@ -248,6 +252,9 @@ int main() { | |||
| Optimizer/zend_dump.c, | |||
| shared,,-DZEND_ENABLE_STATIC_TSRMLS_CACHE=1,,yes) | |||
|
|
|||
| PHP_CHECK_LIBRARY(rt, shm_unlink, [PHP_ADD_LIBRARY(rt,1,OPCACHE_SHARED_LIBADD)]) | |||
|
|
|||
There was a problem hiding this comment.
May be add -lrt in previous chunk?
There was a problem hiding this comment.
-lrt is necessary only with HAVE_SHM_MMAP_POSIX.
dstogov
reviewed
Oct 8, 2019
| @@ -13742,7 +13742,7 @@ if (SLJIT_UNLIKELY(sljit_get_compiler_error(compiler))) | |||
| sljit_free_compiler(compiler); | |||
| SLJIT_FREE(common->optimized_cbracket, allocator_data); | |||
| SLJIT_FREE(common->private_data_ptrs, allocator_data); | |||
| PRIV(jit_free_rodata)(common->read_only_data_head, compiler->allocator_data); | |||
| PRIV(jit_free_rodata)(common->read_only_data_head, allocator_data); | |||
There was a problem hiding this comment.
I suppose, this and following changes are unrelated.
There was a problem hiding this comment.
Yes.... rebase issue.... ignore this
remicollet
force-pushed
the
issue-librt
branch
from
8c92b5c
to
abf7ab0
Compare
dstogov
approved these changes
Oct 8, 2019
|
Applied in 7.4+ |
kelnei
pushed a commit
to iusrepo/php74
that referenced
this pull request
Dec 11, 2019
to ensure opcache is always linked with librt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some build case with have an
undefined symbol: shm_unlinkso we need to explicitly add this library.Notice: this only happens in Fedora >= 31 so with recent gcc 9.2 and glibc 2.30
In older versions (Fedora <= 30) PHP is linked against librt which is enough
In new version, this lib disappear (linker optimization because uneeded ?), so have to be added.
BTW the patch is incomplete, as we also need to build using
--enable-opcache=shareddidn't find the way to have proper default value = "shared" (there is some PHP_ALWARS_SHARED macro, but can't find it definition)