Request #78656 Parse errors classified as highest log-level #4805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
approved these changes
Oct 9, 2019
|
In my opinion, the |
|
Perhaps I was too modest in my approach to this. I would also consider this a bug. It's extremely frustrating receiving error messages in unrelated terminals. |
|
Landing on 7.2 is fine. |
|
Why did the test fail? |
|
@eriklundin, AppVeyor test failure is intermittent (there are several test cases which are occasionally failing). |
|
Thanks for the bug report and the PR! Applied as 3164186. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Parse errors are classified as the highest log level (LOG_EMERG). This is problem since Centos/Fedora writes LOG_EMERG messages to all users:
https://src.fedoraproject.org/rpms/rsyslog/blob/master/f/rsyslog.conf#_59
LOG_EMERG is described as: "system is unusable". A php-script with a parse error would not in most cases render the system unstable. At most LOG_ERR or LOG_CRIT would be more suitable. Fatal errors are classified as LOG_ERR. Why not make parse errors the same level?
The source:
https://github.com/php/php-src/blob/PHP-7.3/main/main.c#L1300
The commit that changed this:
3edf7d9
Bug url:
https://bugs.php.net/bug.php?id=78656