Proposal: Support declare(function_and_const_lookup = 'global')
#4951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC - https://wiki.php.net/rfc/use_global_elements
This adds an implementation and tests for my proposal in
https://news-web.php.net/php.internals/107877
and https://externals.io/message/107953
(those links has background information and why I'm proposing this.
I created this PR to prepare for creating an RFC document,
and demonstrate that this is doable)
Normally, for a non-fully-qualified function or constant name,
PHP would check for
My\NS\my_function()
andMy\NS\MY_CONST
at runtime before checking the global namespace (for every usage).
declare(function_and_const_lookup = global)
would be the same as fully qualifying everyfunction call or constant usage, and avoids the second check.
This would be used as follows:
(No implicit uses are added -
sprintf
should be resolved in the same way in the below examplewhether the function was declared in the same file or a different file)