Add unit test for bug #78902 #4963
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that test case! Usually, we commit such tests together with the bug fix, but if we wanted to commit the test separately, it should definitely have an XFAIL section to avoid that test runners report failure (e.g. CI should be green, and wouldn't be without that section). |
L3o-pold
force-pushed
the
fix/bug78902
branch
from
38e822f to
6f79746
Compare
|
@cmb69 Thanks for you feedback. I added an XFAIL section. |
L3o-pold
force-pushed
the
fix/bug78902
branch
from
6f79746 to
c4b82fe
Compare
Closed
769344359
approved these changes
Dec 16, 2019
|
Merged as f720fb1, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in https://bugs.php.net/bug.php?id=78902 PHP 7.3.11 introduced a bug that was not covered with unit test.