Skip to content

Convert string|array union parameter types #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

Convert strtr() and mail().

@nikic
Copy link
Member

nikic commented Dec 10, 2019

Windows build failure looks legit.

@nikic
Copy link
Member

nikic commented Dec 10, 2019

Not sure, but the Windows test failure might be because the null argument is now accepted (in line with general zpp rules), while previously the second mail call would fail at that point?

It's really hard to say because https://github.com/php/php-src/blob/master/ext/pcre/tests/bug72463_2.phpt uses EXPECTREGEX and I'm not sure what the usual output is and what we get now.

@cmb69 Could you take a look at what's going on here?

@kocsismate
Copy link
Member Author

I also suspected the null argument to be the issue, but wasn't sure and also couldn't try. :/ So, Christoph's help is welcome :)

@cmb69
Copy link
Member

cmb69 commented Dec 20, 2019

Well, indeed, the failing tests hadbeen caused by an unrelated bug which has been fixed in the meantime, and after the rebase everything looks good. I think this is good to be merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants