Rename pcre_printint.src to pcre_printint.c and update from upstream #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rename was done upstream in r836, but the upgrade-pcre.php script doesn't mirror file deletions or creations, so the change didn't propagate to here. The file is only used when CFLAGS=-DPCRE_DEBUG is specified, so nobody noticed. After this change, PHP can be successfully compiled with PCRE_DEBUG. The file is from the PCRE 8.32 tarball. The old pcre_printint.src was from 8.11.
|
Looks like pcre_printint.c is already in use in current master (https://github.com/php/php-src/blob/master/ext/pcre/pcrelib/pcre_printint.c), so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename was done upstream in r836 (http://vcs.pcre.org/viewvc?view=revision&revision=836), but the upgrade-pcre.php script doesn't mirror file deletions or creations, so the change didn't propagate to here. The file is only used when CFLAGS=-DPCRE_DEBUG is specified, so nobody noticed. After this change, PHP can be successfully compiled with PCRE_DEBUG.
The file is from the PCRE 8.32 tarball. The old pcre_printint.src was from 8.11.