Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Dec 30, 2019

We must not use the same shared memory OPcache instance for different
SAPIs, since their memory layout is different. To avoid this, we add
the SAPI name (truncated to at most 20 characters) to the names of the
memory base file, the mutex and the file mapping.

We must not use the same shared memory OPcache instance for different
SAPIs, since their memory layout is different.  To avoid this, we add
the SAPI name (truncated to at most 20 characters) to the names of the
memory base file, the mutex and the file mapping.
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@cmb69
Copy link
Member Author

cmb69 commented Dec 30, 2019

Thanks! Applied as 0cecf83.

@cmb69 cmb69 closed this Dec 30, 2019
@cmb69 cmb69 deleted the cmb/fix-79040 branch December 30, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants