Add support for deprecating internal constants #5072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this also cover internal class constants? Asking because I'm not seeing a test for this. |
|
@Girgias Nope, this currently only supports global constants. |
cmb69
added a commit
to cmb69/php-src
that referenced
this pull request
Jan 16, 2020
Let's wait for PR php#5072, and act accordingly then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal constants can be marked as
CONST_DEPRECATED, in which accessing them will throw a deprecation warning.We've needed this a couple of times in the past, but never bothered to implement it...
cc @cmb69