Fix #79096: FFI Struct Segfault #5079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must not assume that the size of a function's return value is at most `sizeof(ffi_arg)`, but rather have to use the size which already has been determined for the return type if it is larger than `sizeof(ffi_arg)`.
|
Possibly export some APIs from the zend test extension? |
To be able to have a regression test, we export the required test function from the zend-test extension, and make sure that the test can be run on different platforms regardless of whether zend-tests was built statically or dynamically.
nikic
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Looks consistent with man page at https://manpages.debian.org/testing/libffi-dev/ffi_call.3.en.html.
|
Thanks! Applied as 05f3cd2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must not assume that the size of a function's return value is at
most
sizeof(ffi_arg), but rather have to use the size which alreadyhas been determined for the return type if it is larger than
sizeof(ffi_arg).I'm having trouble to come up with a portable regression test using some widely available API; maybe it's worthwhile to integrate building of supportive libs for tests into
configure/make? Or maybe it's not really relevant to support oversized return types (and maybe not even fully supported by libffi?), and to disallow them altogether?