Fix #78969 PASSWORD_DEFAULT should match PASSWORD_BCRYPT instead of being null #5107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng null It was an unintentional BC break.
|
LGTM but maybe @sgolemon wants to chime in. Maybe I'm missing something about why this got changed to null. |
nikic
approved these changes
Jan 27, 2020
|
@nikic Is it ok if the news entry contains the title of this PR or can you suggest me a better text? |
|
@kocsismate It's okay. You should probably also mention this in UPGRADING. |
|
Specifically this line needs to be updated: Line 153 in 41e1891 |
|
Closing via ea1b878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to supersede #5104 in order to fix the real issue.