Fix #78090: test 3408/14609 of make test takes forever to finish #5146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all systems support the discard protocol (TCP port 9), so we skip this test, if the system does not.
cmb69
changed the title
Apparently, connecting to port 9 is not supported (so the test is now skipped on Travis). Presumably, we have to check for a timeout.
|
Is the use of |
|
Indeed, there shouldn't be an issue using our own server, and that would also make it possible to run the test on so-far unsupported systems. I've also adapted bug46739.phpt accordingly; the only other test I could find which used port 9 as well. |
cmb69
changed the title
|
Applied as 079905a. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all systems support the discard protocol (TCP port 9), so we skip
this test, if the system does not.