Skip to content

Fix #79276: PDO ignores any placeholder between two '\' #5190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #79276: PDO ignores any placeholder between two '\' #5190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/pdo/pdo_sql_parser.re
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ static int scan(Scanner *s)
*/

/*!re2c
(["](([\\]ANYNOEOF)|ANYNOEOF\["\\])*["]) { RET(PDO_PARSER_TEXT); }
(['](([\\]ANYNOEOF)|ANYNOEOF\['\\])*[']) { RET(PDO_PARSER_TEXT); }
(["](ANYNOEOF\["]|"")*["]) { RET(PDO_PARSER_TEXT); }
(['](ANYNOEOF\[']|'')*[']) { RET(PDO_PARSER_TEXT); }
MULTICHAR { RET(PDO_PARSER_TEXT); }
ESCQUESTION { RET(PDO_PARSER_ESCAPED_QUESTION); }
BINDCHR { RET(PDO_PARSER_BIND); }
Expand Down
40 changes: 40 additions & 0 deletions ext/pdo/tests/bug_79276.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
--TEST--
Bug #79276 (PDO ignores any placeholder between two '\')
--SKIPIF--
<?php
if (!extension_loaded('pdo')) die('skip pdo extension not available');
$dir = getenv('REDIR_TEST_DIR');
if (false == $dir) die('skip no driver');
require_once $dir . 'pdo_test.inc';
PDOTest::skip();
?>
--FILE--
<?php
if (getenv('REDIR_TEST_DIR') === false) putenv('REDIR_TEST_DIR='.__DIR__ . '/../../pdo/tests/');
require_once getenv('REDIR_TEST_DIR') . 'pdo_test.inc';
$db = PDOTest::factory();
if (!strncasecmp(getenv('PDOTEST_DSN'), 'mysql', strlen('mysql'))) {
$db->exec("SET SESSION sql_mode = 'NO_BACKSLASH_ESCAPES'");
}

$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);

$create_sql = "CREATE TABLE test (foo INT, bar VARCHAR(10))";
$db->exec($create_sql);

$insert_sql = "INSERT INTO test VALUES (1, '\\')";
$db->exec($insert_sql);

$sql = "SELECT * FROM test WHERE bar = '\\' AND foo = :foo AND bar = '\\'";
$sth = $db->prepare($sql);
$sth->execute(['foo' => 1]);
$row = $sth->fetch(PDO::FETCH_NUM);
var_dump($row);
?>
--EXPECT--
array(2) {
[0]=>
string(1) "1"
[1]=>
string(1) "\"
}