Imap send #52

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

Keloran commented Apr 11, 2012

This is a cleanup of my imap_mail patch,

it attempts to fix the following bug
https://bugs.php.net/bug.php?id=30688

+ int rpath_length = strlen(rpath);
+ int sendmail_length = strlen(sendmail_path);
+ char *force_extra_parameters = INI_STR("mail.force_extra_parameters");
+ char *extra_cmd = NULL;
@johannes

johannes Apr 11, 2012

Owner

Declarations have to go first in the block to be compliant with ANSI C. Either move the declarations up or put this in a block.

+
+ if (rpath && rpath[0]) {
+ appended_sendmail_path = emalloc(sendmail_length + 3 + rpath_length + 1);
+ strncpy(appended_sendmail_path, sendmail_path, 50);
@johannes

johannes Apr 11, 2012

Owner

Where does the 50 come from?

+ if (rpath && rpath[0]) {
+ appended_sendmail_path = emalloc(sendmail_length + 3 + rpath_length + 1);
+ strncpy(appended_sendmail_path, sendmail_path, 50);
+ strncat(appended_sendmail_path, " -f", 3);
@johannes

johannes Apr 11, 2012

Owner

Instead of using the magic constant 3 one might use sizeof(" -f")-1. If the above magic 50 is fixed one might probably calculate the offset in append_sendmail_path and use strncpy here, too

+ }
+
+ if (extra_cmd) {
+ spprintf(&sendmail_path, 0, "%s %s", sendmail_path, extra_cmd);
@johannes

johannes Apr 11, 2012

Owner

won't this change INI_STR("sendmail_path")? (at least if !rpath || !rpath[0] )

Contributor

smalyshev commented Jul 22, 2013

Looks like this patch is abandoned - no response to comments for a year. I am closing this pull, if somebody is interested in taking it to completion please reopen it.

Comment on behalf of stas at php.net:

closing

@php-pulls php-pulls closed this Jul 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment