Skip to content

Fix #79200: Some iconv functions cut Windows-1258 #5231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Mar 3, 2020

To cater to potentially state-dependent encodings, we have to reset the
conversion descriptor into its initial shift state to properly finish
the conversion. Furthermore, state-dependent encodings may not show
progress when comparing in_left before and after the conversion; we
rather have to see whether out_left has decreased. Also we have to
cater to the fact that the final potentially state resetting call does
not signal failure, but we still have to break respective loops
afterwards.

To cater to potentially state-dependent encodings, we have to reset the
conversion descriptor into its initial shift state to properly finish
the conversion.  Furthermore, state-dependent encodings may not show
progress when comparing `in_left` before and after the conversion; we
rather have to see whether `out_left` has decreased.  Also we have to
cater to the fact that the final potentially state resetting call does
not signal failure, but we still have to break respective loops
afterwards.
@cmb69 cmb69 added the Bug label Mar 3, 2020
@cmb69
Copy link
Member Author

cmb69 commented Mar 16, 2020

If there are no objections, I'll merge this in a week.

Ensure that iconv() behaves as expected.
@cmb69
Copy link
Member Author

cmb69 commented Mar 23, 2020

Thanks! Applied as 32a2644.

@cmb69 cmb69 closed this Mar 23, 2020
@cmb69 cmb69 deleted the cmb/79200 branch March 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants