Fix #50678 files extracted by ZipArchive class lost their original mo…

[remicollet]

…dified time

[remicollet]

@cmb69 as this is another implementation of pr #1291

[remicollet]

There is small TZ issue, which looks like (to me) as an issue in libzip.

[cmb69]

There is small TZ issue, which looks like (to me) as an issue in libzip.

Yeah, I faced that issue with the othe PR as well; it worked locally, but failed on CI. The problem might be that at least the MS DOS time format does not even specify a timezone.

Anyhow, to work around that in the test case by just ignoring the hours/minutes/seconds might still be brittle; maybe it would be better to not print the timestamp directly, but rather to check whether it is within a permissible range?

[remicollet]

Ok, found the explanation, "local" time is stored (which may be different from file system time)

BTW, everything works as expected:

• zip / unzip => same time
• zip / ZipArchive::extractTo => same time
• ZipArchvie::addFile / unzip => same time
• ZipArchvie::addFile / ZipArchive::extractTo => same time

And finally found a better test (compare date of saved / restored file, which is exactly the goal)

[remicollet]

Grr... "better" test fails... do definitively some issue in testing env, so reverting to the previous partial test (checking only date, not time)

[remicollet]

About test; "zip" format only allow even second, which may explain some failure

See https://libzip.org/documentation/zip_file_set_dostime.html

[remicollet]

Merged