Fix #78210: Invalid pointer address #5247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually about three distinct issues: * If an empty string is passed as $address to `stream_socket_sendto()`, the `sa` is not initialized, so we must not pass it as `addr` to `php_stream_xport_sendto()`. * On POSIX, `recvfrom()` truncates messages which are too long to fit into the specified buffer (unless `MSG_PEEK` is given), discards the excessive bytes, and returns the buffer length. On Windows, the same happens, but `recvfrom()` returns `SOCKET_ERROR` with the error code `WSAEMSGSIZE`. We have to catch this for best POSIX compatibility. * In `php_network_parse_network_address_with_port()`, we have to zero `in6` (not only its alias `sa`) to properly support IPv6.
nikic
approved these changes
Mar 10, 2020
Co-Authored-By: Nikita Popov <nikita.ppv@googlemail.com>
|
Thanks! Applied as 53797c2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually about three distinct issues:
If an empty string is passed as $address to
stream_socket_sendto(),the
sais not initialized, so we must not pass it asaddrtophp_stream_xport_sendto().On POSIX,
recvfrom()truncates messages which are too long to fitinto the specified buffer (unless
MSG_PEEKis given), discards theexcessive bytes, and returns the buffer length. On Windows, the same
happens, but
recvfrom()returnsSOCKET_ERRORwith the error codeWSAEMSGSIZE. We have to catch this for best POSIX compatibility.In
php_network_parse_network_address_with_port(), we have to zeroin6(not only its aliassa) to properly support IPv6.