Mark writes that are really reads if working on an object #5273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #5250 that I think handles the readonly property case more comprehensively.
We add a flag to the FETCH_OBJ_W/RW/UNSET opcodes that tells us whether the write should be interpreted as a read if the fetched value is an object. This is passed on to read_property as an extra flag in the BP_VAR mode.
Here this is used to make the "indirect modification" warning more accurate -- but the same check would also apply to readonly properties.
This change is likely incomplete because it makes BP_VAR a mask, so some equality comparisons may need to be adjusted.