Skip to content

Fix #79462: method_exists and property_exists incoherent behavior #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #79462: method_exists and property_exists incoherent behavior #5362

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Apr 9, 2020

Both functions are closely related, so should behave the same for wrong
input types, i.e. both should throw a TypeError.

@cmb69
Fix #79462: method_exists and property_exists incoherent behavior
e5dbe99 
Both functions are closely related, so should behave the same for wrong
input types, i.e. both should throw a TypeError.
carusogabriel
carusogabriel reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the ZPP handle union types already?

Could we use it to replace the if/elseif/else block?

nikic
nikic approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@cmb69
Copy link
Member Author

cmb69 commented Apr 9, 2020

Does the ZPP handle union types already?

No.

@cmb69
Copy link
Member Author

cmb69 commented Apr 9, 2020

Thanks! Applied as e6458d6.

@cmb69 cmb69 closed this Apr 9, 2020
@cmb69 cmb69 deleted the cmb/79462 branch April 9, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

+1 more reviewer

@carusogabriel carusogabriel carusogabriel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmb69 @nikic @carusogabriel