Skip to content

Fix #79472: ext/ffi/tests/040.phpt TC fails on Big endian arch #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Apr 13, 2020

For now we are choosing the simplest solution, namely to skip the test
on big-endian architectures.

For now we are choosing the simplest solution, namely to skip the test
on big-endian architectures.
@cmb69 cmb69 changed the base branch from master to PHP-7.4 April 13, 2020 21:26
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if instead, we add an XFAIL section?

@cmb69
Copy link
Member Author

cmb69 commented Apr 14, 2020

We could dynamically mark the test as xfail for big-endian architectures (i.e. s/skip/xfail), but skipping seems to be more inline with what we usually do for 32/64bit only tests. Might be better, if we make the test to succeed on little-endian as well as big-endian, or maybe to split the test.

@nikic
Copy link
Member

nikic commented Apr 14, 2020

By the way, I think we should add a constant like PHP_BIG_ENDIAN to make such checks simpler.

@vibhutisawant
Copy link
Contributor

@cmb69
These testcases fail on Big endian arch as they appear to be Little endian arch specific

  • ext/exif/tests/float_cast_overflow.phpt
  • ext/exif/tests/bug79046.phpt

Below mentioned bugs were raised for the same
79279 and 79336

Can they also be skipped?

@nikic
Copy link
Member

nikic commented Apr 14, 2020

@vibhutisawant Those failures indicate an implementation bug, which needs to be fixed.

@dstogov
Copy link
Member

dstogov commented Apr 14, 2020

Merged as 8c5faf7

@dstogov dstogov closed this Apr 14, 2020
@cmb69 cmb69 deleted the cmb/79472 branch April 14, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants