Avoid throw expression leaks #5450
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
reviewed
Apr 24, 2020
| Caught | ||
| Caught | ||
| Caught | ||
| int(32767) |
There was a problem hiding this comment.
Could this use the following to override the users php.ini settings instead, to avoid test failures when a tester already installed something to the configured --prefix and added ini settings?
--INI--
error_reporting=E_ALL
There was a problem hiding this comment.
This is already enforced by run-tests.
There was a problem hiding this comment.
See
Line 236 in d5e51fc
|
LGTM other than the question |
iluuu1994
reviewed
Apr 25, 2020
iluuu1994
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the hack suggested by @TysonAndre. We mark
throwif it is used in expression context, and don't treat it as a terminator in that case.This gives us a bit less optimization opportunity, but avoids the complexity of #5448 or other "proper" solutions.