Improve error message when the first argument of __state_state isn'…
#5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t typed as array Currently, the error message shown to the user is: ``` Argument 1 passed to A::__set_state() must be of the type string, array given ``` Which isn't necessary that. The problem is before that: the type that is actually wrong. With this patch, the error message now is: ``` Type of first argument of Foo::__set_state() must be array ```
kocsismate
reviewed
Apr 26, 2020
| && ZEND_TYPE_IS_SET(fptr->common.arg_info[0].type) | ||
| && ZEND_TYPE_FULL_MASK(fptr->common.arg_info[1].type) != MAY_BE_ARRAY | ||
| ) { | ||
| zend_error(error_type, "Type of first argument of %s::__set_state() must be array", ZSTR_VAL(ce->name)); |
There was a problem hiding this comment.
Can you please use the %s::__set_state(): Argument #1 ($%s) must be of type array, %s given form?
There was a problem hiding this comment.
I'll adopt it in #4177, thanks!
|
I don't understand why this is separate from #4177. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t typed as array
Currently, the error message shown to the user is:
Which isn't necessary that. The problem is before that: the type that is actually wrong. With this patch,
the error message now is:
This is proposed separately from #4177 as I believe is an improvement, not a BC.