Fix #79539: during CI, drop table if it exists #5493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI fails on mysqli_insert_packet_overflow.phpt based on what mysqli tests are run, because the test db sometimes lingers. This fix drops the table if it exists, as most tests do.
|
Thanks for the PR (and for checking AppVeyor CI in the first place)! :) However, this is indeed a duplicate of PR #5447 (and PR ##5479 has a more comprehensive solution), and we're still hoping to find the root cause of the issue, so deleting the table just before creating it would only be a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI fails on mysqli_insert_packet_overflow.phpt based on what mysqli
tests are run, because the test db sometimes lingers. This fix drops
the table if it exists, as most tests do.