Use Timsort for sorting #5559
Closed
Use Timsort for sorting #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is taken from https://github.com/patperry/timsort.
Closed
|
Fix for Windows: win32/build/config.w32 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/win32/build/config.w32 b/win32/build/config.w32
index 62dbeb40d9..048886e60a 100644
--- a/win32/build/config.w32
+++ b/win32/build/config.w32
@@ -236,7 +236,7 @@ ADD_SOURCES("Zend", "zend_language_parser.c zend_language_scanner.c \
zend_object_handlers.c zend_objects_API.c \
zend_default_classes.c zend_execute.c zend_strtod.c zend_gc.c zend_closures.c zend_weakrefs.c \
zend_float.c zend_string.c zend_generators.c zend_virtual_cwd.c zend_ast.c \
- zend_inheritance.c zend_smart_str.c zend_cpuinfo.c");
+ zend_inheritance.c zend_smart_str.c zend_cpuinfo.c zend_timsort.c");
ADD_FLAG("CFLAGS_BD_ZEND", "/D ZEND_ENABLE_STATIC_TSRMLS_CACHE=1");
if (VS_TOOLSET && VCVERS >= 1914) { |
| * | ||
| * arraySizes minRun = cumSums (binSizes minRun) | ||
| * | ||
| * We these funcitons, we can compute a table with minRun = MIN_MERGE / 2 = 16: |
There was a problem hiding this comment.
We these funcitons -> With these functions ?
(the original code has the same "mistake": https://github.com/patperry/timsort/blob/9fc97ae0857e4fbce06c1b6b26b48e427e307895/timsort.c#L262)
| * ], | ||
| * | ||
| * Moreover, minRun >= MIN_MERGE / 2. Also, note that the sum of the | ||
| * run lenghts is less than or equal to the length of the array. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick test, with the implementation taken from https://github.com/patperry.
Many test failures due to differences in performed comparisons.