General support for reparse points which are not named surrogates #5565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the docs[1], and given our experience with reparse point resolution for `realpath()`, it seems to be safe to assume that all reparse points, which are not named surrogates, are not aliased, so their absolute paths are their real paths. By doing so, we support arbitrary third party on-demand file systems out of the box, without the need to eventually add support for individual reparse tags. [1] <https://docs.microsoft.com/en-us/windows/win32/api/winnt/nf-winnt-isreparsetagnamesurrogate>
KalleZ
approved these changes
Jul 15, 2020
|
Thanks, @KalleZ! If there are no objections, I'll merge this in a week. |
|
@cmb69 this looks like a great simplification. Though, is this supported by some QA? All the points touched need a serious validation, especially dedup and one drive ones. Thanks. |
|
I only did basic QA (testing some reparse points, including VFS for Git), but I'm afraid extensive testing is not possible for me due to lack of resources. |
|
At least the two mentioned could be checked by a simple test run with tests placed on onedrive/smb. These two was subjects of bug reports in the past. thanks. |
|
I'm closing this for time reasons. Anyone who's willing to take this up is welcome to do so! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs[1], and given our experience with reparse point
resolution for
realpath(), it seems to be safe to assume that allreparse points, which are not named surrogates, are not aliased, so
their absolute paths are their real paths. By doing so, we support
arbitrary third party on-demand file systems out of the box, without
the need to eventually add support for individual reparse tags.
[1] https://docs.microsoft.com/en-us/windows/win32/api/winnt/nf-winnt-isreparsetagnamesurrogate