Skip to content

Fix #79653 Unexpected error for ArrayIterator::ksort() #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix #79653 Unexpected error for ArrayIterator::ksort() #5644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/spl/spl_array.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public function asort($sort_flags = SORT_REGULAR) {}
/**
* @param int $sort_flags
* @return bool
* @alias ArrayObject::offsetExists
* @alias ArrayObject::ksort
*/
public function ksort($sort_flags = SORT_REGULAR) {}

Expand Down
2 changes: 1 addition & 1 deletion ext/spl/spl_array_arginfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ static const zend_function_entry class_ArrayIterator_methods[] = {
ZEND_MALIAS(ArrayObject, getFlags, getFlags, arginfo_class_ArrayIterator_getFlags, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, setFlags, setFlags, arginfo_class_ArrayIterator_setFlags, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, asort, asort, arginfo_class_ArrayIterator_asort, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, ksort, offsetExists, arginfo_class_ArrayIterator_ksort, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, ksort, ksort, arginfo_class_ArrayIterator_ksort, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, uasort, uasort, arginfo_class_ArrayIterator_uasort, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, uksort, uksort, arginfo_class_ArrayIterator_uksort, ZEND_ACC_PUBLIC)
ZEND_MALIAS(ArrayObject, natsort, natsort, arginfo_class_ArrayIterator_natsort, ZEND_ACC_PUBLIC)
Expand Down
24 changes: 24 additions & 0 deletions ext/spl/tests/arrayIterator_ksort_basic1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
--TEST--
Bug #79653: Unexpected error for ArrayIterator::ksort()
--FILE--
<?php

$array = [3 => 1, 2 => 2, 1 => 3];
$arrIter = new ArrayIterator($array);
var_dump($arrIter->ksort());
var_dump($arrIter);

?>
--EXPECT--
bool(true)
object(ArrayIterator)#1 (1) {
["storage":"ArrayIterator":private]=>
array(3) {
[1]=>
int(3)
[2]=>
int(2)
[3]=>
int(1)
}
}