Skip to content

Fix #73527: Invalid memory access in php_filter_strip #5660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix #73527: Invalid memory access in php_filter_strip #5660

wants to merge 2 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jun 4, 2020

No description provided.

nikic
nikic approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: The + 1 in the allocation is incorrect. zend_string_alloc adds +1 for the null byte itself.

@cmb69
Fix useless overallocations
48c04ed 
`zend_string_init()` already adds space for the NUL byte.
@cmb69
Copy link
Member Author

cmb69 commented Jun 4, 2020

Thanks! Applied as ceae816.

@cmb69 cmb69 closed this Jun 4, 2020
@cmb69 cmb69 deleted the cmb/73527 branch June 4, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmb69 @nikic