Fix #66937: transformToDoc() removes DTD of source document #5704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsltApplyStylesheetUser() removes the DTD from the given document; we counteract this by adding it back after the function returned.
|
@beberlei, any thoughts on this? See also https://mail.gnome.org/archives/xslt/2020-June/msg00001.html. |
|
On purpose, but the purpose was forgotten :( tricky, i feel this should be fixed, but then again must be the even more destructive operations hinted at. Maybe a documentation issue about the param being muted? I am torn |
|
I'm at a loss here as well. Making that a doc issue would still mean that users may have to actually duplicate the source document to be able to restore it afterwards. OTOH, trying to fix all potential modifications to the source document would likely require to do this internally, what may be worse. |
|
Well, after reconsideration, it seems it's best to change https://bugs.php.net/66937 to doc problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xsltApplyStylesheetUser() removes the DTD from the given document; we
counteract this by adding it back after the function returned.
Given that this bug has been reported more than 6 years ago, targeting master may be more reasonable. And maybe we just want to close the ticket as WONTFIX.