Skip to content

Update to PCRE2 10.35 #5783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update to PCRE2 10.35 #5783

wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jun 30, 2020

I'm not actually propsing this for PHP-7.4 (master should be a no-brainer, though); just for your consideration. This update would resolve bug #79363.

See also the PCRE2 changelog.

@halaei
Copy link

halaei commented Jun 30, 2020

Thanks for the PR.

I am not totally aware of the reasons for doubts about having this PR in 7.4. But it seems moving from PCRE 10.33 to 10.34 has been done inside PHP 7.3 and 7.4, if I am not mistaking. Therefore, maybe moving from 10.34 to 10.35 is also OK and can be regarded as just bug fixes and new minor features, but not breaking expected behaviours.

@cmb69
Copy link
Member Author

cmb69 commented Jun 30, 2020

But it seems moving from PCRE 10.33 to 10.34 has been done inside PHP 7.3 and 7.4, […]

PHP 7.3 is still on PCRE2 10.32, and PHP 7.4 only has been updated to PCRE2 10.34 after some time master had been updated to 10.34.

@nikic
Copy link
Member

nikic commented Jun 30, 2020

Right. Let's follow the same process here. Upgrade master first and then revisit 7.4 after a while.

@cmb69
Copy link
Member Author

cmb69 commented Jun 30, 2020

Fine. Applied to master as b419f96.

@cmb69 cmb69 closed this Jun 30, 2020
@cmb69 cmb69 deleted the cmb/pcre2-10.35 branch June 30, 2020 14:20
@carusogabriel
Copy link
Contributor

This update would resolve bug #79363.

@cmb69 Should a test case be added for that?

@cmb69
Copy link
Member Author

cmb69 commented Jun 30, 2020

@carusogabriel, given that it has been an upstream issue, and PCRE2 has its own test suite, I don't think this is necessary.

@alexbusu
Copy link

@cmb69 Hi! When we will have the 10.35 in PHP 7.4.x, could you tell, please?

@nikic
Copy link
Member

nikic commented Sep 17, 2020

This has been in master for a while now, I think it's okay to update 7.4 now.

@cmb69 cmb69 restored the cmb/pcre2-10.35 branch September 17, 2020 09:50
@cmb69 cmb69 reopened this Sep 17, 2020
@cmb69
Copy link
Member Author

cmb69 commented Sep 17, 2020

Thanks for the reminder!

@cmb69
Copy link
Member Author

cmb69 commented Sep 17, 2020

Applied to PHP-7.4 as 9f2d039.

@cmb69 cmb69 closed this Sep 17, 2020
@cmb69 cmb69 deleted the cmb/pcre2-10.35 branch September 17, 2020 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants