Fix #73060: php failed with error after temp folder cleaned up #5875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of storing the mapping base address and the address of `execute_ex()` in a separate file in the temporary folder, we store them right at the beginning of the memory mapping.
|
Any thoughts on this? @dstogov, do you see any technical issues with storing the base addresses in the SHM, instead in a file? |
|
@cmb69 keeping addresses in SHM should be fine. |
|
Thanks, @dstogov! I've pushed some minor improvements, tested again, and I'm planning to merge this PR, when CI has passed. I'll do more extensive testing when the snapshots are available. |
|
Applied as 9a744c6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing the mapping base address and the address of
execute_ex()in a separate file in the temporary folder, we storethem right at the beginning of the memory mapping.
Note that https://bugs.php.net/73060 has been closed as WONTFIX by @weltling long ago, but I don't see why this issue should not be addressed – in my opinion, cleaning the temp folder from time to time shouldn't cause new worker processes failing to start.