Fix #77932: File extensions are case-sensitive #5898
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file extension to mime type mapping *must* not depend on the file extension's case for case-insensitive file systems, and *should* not for case-sensitive file systems.
nikic
reviewed
Jul 27, 2020
I don't disagree, but do you happen to know if other servers (like apache or nginx) treat the extension case-insensitively on case-sensitive file systems as well? |
|
For Apache's AddEncoding directive and NGinX's type directive, the file extension is documented to be case-insensitive. |
nikic
approved these changes
Jul 27, 2020
|
Thanks! Applied as 6f18d7e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file extension to mime type mapping must not depend on the file
extension's case for case-insensitive file systems, and should not
for case-sensitive file systems.