Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small CS fix #5975

Closed
wants to merge 2 commits into from
Closed

Small CS fix #5975

wants to merge 2 commits into from

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Aug 12, 2020

Just a super minor thing I found when browsing the source code.

This file might be easier to view than the diff: https://github.com/php/php-src/blob/1e9a5c67ef6d075df16d4183abf62e4c99b2f8c6/sapi/fpm/fpm/fpm_request.h

@thg2k
Copy link
Contributor

thg2k commented Aug 12, 2020

I have a ton of stuff like this in my git... i never know whether i should PR those. Let's see if this one is accepted, I might start to submit mine.

@nikic
Copy link
Member

nikic commented Aug 12, 2020

It would be better to fix this by removing alignment. That is, move the comments before the declaration.

@Nyholm
Copy link
Contributor Author

Nyholm commented Aug 12, 2020

I usually dont poke around in this repo. But Im currently trying to track down a nasty bug in my app and I saw this file while I was working.

Feel free to close if the maintainers think this is just noise.

@php-pulls php-pulls closed this in 3485ec4 Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants