Skip to content

Fix #79968: Manipulation on unattached DOMChildNode should throw DOMException #5990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix #79968: Manipulation on unattached DOMChildNode should throw DOMException #5990

wants to merge 1 commit into from

Conversation

beberlei
Copy link
Contributor

@beberlei beberlei commented Aug 15, 2020 •
edited
Loading

This fixes https://bugs.php.net/bug.php?id=79968

Missing logic implemented from specification:

node . before(...nodes)

    Inserts nodes just before node, while replacing strings in nodes with equivalent Text nodes.

    **Throws a "HierarchyRequestError" DOMException if the constraints of the node tree are violated.**

@beberlei
Copy link
Contributor Author

Fixed in 9f6820f

@beberlei beberlei closed this Aug 19, 2020
@nielsdos nielsdos mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beberlei @nikic