Create an object oriented interface for Hash Context #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| zend_replace_error_handling(EH_THROW, NULL, &error_handling TSRMLS_CC); |
There was a problem hiding this comment.
Error handling must be replaced before the zpp call already, otherwise you'll end up with new returning null.
There was a problem hiding this comment.
Fixed that, thanks.
|
Closing in favor of #660. This way we can discuss the object oriented interface at a later time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I liked the idea, recently mentioned on internals, to remove the use of resources on use object oriented APIs instead.
This pull request does just that, by introducing the class
HashContext. It's targeted at master, since this should go into PHP 5.7.Tests all pass, one required modification as it relied on the output of var_dump. The B/C break is very small, code that relies on checking
is_resource()fails and needs to be changed to also do `ìnstanceof HashContext``.A quick search on GitHub revealed no project that uses HashContext in the global namespace.