Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use external iterator instead of via the internal pointer" #6242

Conversation

cmb69
Copy link
Contributor

@cmb69 cmb69 commented Sep 29, 2020

This reverts commit a6ecafe.


Just checking whether this fixes the test failure, which I cannot reproduce locally.

@cmb69
Copy link
Contributor Author

cmb69 commented Sep 29, 2020

Ah, the actual problem is that odbc_execute() may coerce the array elements to string (obviously, that segfaults with opcache.protect_memory), what is a bug on its own.

@php-pulls php-pulls closed this in 07fa130 Sep 29, 2020
@cmb69 cmb69 deleted the cmb/revert-a6ecafece90909d74a578e09f626e875d3035eab branch September 29, 2020 23:32
@nikic
Copy link
Member

nikic commented Sep 30, 2020

Oh... so the array separation fixed a second bug by accident? ^^

@cmb69
Copy link
Contributor Author

cmb69 commented Sep 30, 2020

Not really, but an aspect of the issue I wasn't aware of. Anyway, see PR #6243.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants