Make DateInterval::createFromDateString() throw an exception on invalid date strings #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This only has a test, which fails. |
|
@smalyshev Well, they say the best start is a failing test case ;-) I'll look into this! |
|
Can one of the admins verify this patch? |
|
This PR is so old that the master branch has moved, this is a patch against 5 series. Since a patch against a supported branch is going to look very different, and since this hasn't generated enough interest to have it merged, I'm going to close this PR. Please take this action as encouragement to open a PR against a supported branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses feature request 50020.
It throws an exception if
DateInterval::createFromDateString()is given an invalid time string.