Fix #80771: phpinfo(INFO_CREDITS) displays nothing in CLI #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no good reason not to show the credits in text based SAPIs.
nikic
reviewed
Feb 18, 2021
|
Looks like this behavior dates all the way back to 6676617. |
Indeed. Anyhow, given this long standing behavior, might be better to fix for PHP-8.0 or "master" only? |
|
I suspect that the reason why this is omitted, it to make the output more compact (which matters a bit more on CLI than web). I do think we should be showing the full output for phpinfo() though. However, might it make sense to remove the CREDITS flag from |
Yes, that makes sense. |
nikic
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no good reason not to show the credits in text based SAPIs.