Fix #51903: simplexml_load_file() doesn't use HTTP headers #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `encoding` attribute of the XML declaration is optional; it is good practice to use external encoding information where available if it is missing. Thus, we check for `charset` info of `Content-Type` headers, and see whether the encoding is supported. This is just a PHP 7.4+ compatible update of Mike's patch. Co-authored-by: Michael Wallner <mike@php.net>
|
cc @m6w6 |
nikic
reviewed
Mar 3, 2021
nikic
reviewed
Mar 3, 2021
Of course, a buffer should be an array.
We do not need to cater to escaped backslashes and quotes in quoted-strings, since no known character encoding contains these.
|
The AppVeyor fail is unrelated (this is being worked on). I don't understand why the Azure pipeline hasn't been trigger for the latest commit, though. |
|
Thanks @nikic! Now all tests passed. |
nikic
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
encodingattribute of the XML declaration is optional; it is goodpractice to use external encoding information where available if it is
missing. Thus, we check for
charsetinfo ofContent-Typeheaders,and see whether the encoding is supported.
This is just a PHP 7.4+ compatible update of Mike's patch.
Co-authored-by: Michael Wallner mike@php.net