Improve fix for #80783 #6842
Improve fix for #80783 #6842
Conversation
|
@cmb69 can you please check, as you are the author of previous fix. |
|
Also open https://bugzilla.redhat.com/1947353 for discussion with unixODBC maintainer for Fedora |
There was a problem hiding this comment.
Oh, I see. This patch looks good to me. Thanks!
Generally, most of odbc_stmt_get_col() looks fishy to me. First, we should not read binary data as SQL_C_CHAR, and secondly, we should not read in small chunks (while a comment states that this would usually be more efficient, I doubt so, and the required tinkering is prone to error). Changing the latter should better not be done in a stable release, and changing the former would be a BC break …
I agree, sounds strange to allocate per small 256 steps, when we know the need size... |
|
merged as 25f5a1b |
Working on new tests introduced in previous fix bccca0b
I notice some driver may return SQL_SUCCESS instead of SQL_SUCCESS_WITH_INFO, but with fetch len > 255
Tried with unixODBC 2.3.9 and [MySQL][ODBC 8.0(w) Driver][mysqld-5.5.5-10.4.18-MariaDB]
P.S. issue only affects binary columuns, not char ones, so bug80783.phpt, not bug80783a.phpt