Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform variable syntax #686

Closed
wants to merge 33 commits into from

Conversation

@nikic
Copy link
Member

commented Jun 6, 2014

@Tyrael

This comment has been minimized.

Copy link
Member

commented Jun 6, 2014

awesome!

@JanTvrdik

This comment has been minimized.

Copy link

commented Jun 8, 2014

👍

1 similar comment
@hrach

This comment has been minimized.

Copy link

commented Jun 8, 2014

👍

@smalyshev

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2014

I like it. 👍

@brandonwamboldt

This comment has been minimized.

Copy link

commented Jun 9, 2014

👍 Would love to have these changes

@rquadling

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2014

Brilliant work. Very very impressed. Is there a way to determine how much
(if any) actual uses of the incompatible usages there are in common
apps/libraries? I suppose that is EXACTLY why unit testing exists, but as
well all know, not everything is.

But that aside, the RFC is very clear and understandable.

On 9 June 2014 16:08, Brandon Wamboldt notifications@github.com wrote:

[image: 👍] Would love to have these changes


Reply to this email directly or view it on GitHub
#686 (comment).

Richard Quadling
Twitter : @rquadling
EE : http://e-e.com/M_248814.html
Zend : http://bit.ly/9O8vFY

@Tyrael

This comment has been minimized.

Copy link
Member

commented Jun 9, 2014

@rquadling the RFC mentions testing two mainstream php framework (ZF and Symfony, would be nice showing the exact version numbers tested) but ofc. running more userland unittests agains phpng and this particular PR would be helpful for indentifying the severity of the BC breaks.

@echochamber

This comment has been minimized.

Copy link

commented Jun 9, 2014

👍

3 similar comments
@hfern

This comment has been minimized.

Copy link

commented Jun 10, 2014

👍

@maroon775

This comment has been minimized.

Copy link

commented Jun 17, 2014

👍

@KonstantinKuklin

This comment has been minimized.

Copy link

commented Jun 21, 2014

👍

@igor822

This comment has been minimized.

Copy link

commented Jun 22, 2014

Yess

@Hywan

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2014

👍

@php-pulls

This comment has been minimized.

Copy link

commented Aug 26, 2014

Comment on behalf of nikic at php.net:

Closing, as this has been merged.

@php-pulls php-pulls closed this Aug 26, 2014

@mbrevda mbrevda referenced this pull request Dec 23, 2014

Closed

Function chained call #301

@jwatzman jwatzman referenced this pull request Aug 19, 2015

Closed

Uniform variable syntax #5523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.