[RFC] Partial Function Application #6898
Conversation
|
I'm missing a test for |
Zend/tests/partial_function/variadics-named-nested-overwrite.phpt
Outdated
Show resolved
Hide resolved
Zend/zend_partial.c
Outdated
| ZVAL_PTR(&partial->This, Z_OBJCE(call->This)); | ||
|
|
||
| GC_ADD_FLAGS(Z_OBJ(call->This), IS_OBJ_DESTRUCTOR_CALLED); | ||
| OBJ_RELEASE(Z_OBJ(call->This)); |
There was a problem hiding this comment.
So for the new Foo(?) case, we first create an object, then destroy it and then if the partial is invoked, create another object.
This is non-great, though I'm not sure just how non-great it is. In conjunction with https://wiki.php.net/rfc/new_in_initializers it could mean that property default values get instantiated and immediately dropped again (though arguably that's an issue with that RFC).
There was a problem hiding this comment.
If we have space for a flag, we could use IS_OBJ_CONSTRUCTOR_CALLED here and use the initial object ...
krakjoe
force-pushed
the
partials
branch
2 times, most recently
from
d264f87
to
61e7f1e
Compare
krakjoe
force-pushed
the
partials
branch
3 times, most recently
from
11123b8
to
286e16f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| } | ||
| ZEND_ASSERT(0); | ||
| return -1; |
There was a problem hiding this comment.
Indentation: mix of tabs and spaces.
|
We lost :( |
|
What's next? Will there be an alternative from Nikita, or your collaboration? |
|
Damn shame, it looks to me like a very useful feature to have. |
Implementation for https://wiki.php.net/rfc/partial_function_application