Skip to content

Conversation

nikic
Copy link
Member

@nikic nikic commented Apr 28, 2021

No description provided.

Copy link
Contributor

@TysonAndre TysonAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, I'd been wondering if there were plans to add these checks in debug builds

@nikic
Copy link
Member Author

nikic commented May 26, 2021

LGTM in general, I'd been wondering if there were plans to add these checks in debug builds

I'm not entirely sure we want to add them to debug builds, as it seems like a relatively expensive check to add to each call.

@krakjoe
Copy link
Member

krakjoe commented May 27, 2021

Possibly add ZEND_FUNC_INFO_DEBUG a la RC_DEBUG ?

This seems like the sort of thing we might want to enable when we're doing certain things, but not really all the time for any type of build - there'll be no ZEND_FUNC_INFO_DEBUG on CI I guess ordinarily, but we might want to enable it in a specific PR, or while we test a PR locally.

@nikic nikic force-pushed the verify-func-info branch from d33c5a4 to 94a5f43 Compare July 21, 2021 09:08
@nikic nikic closed this in 7b85d3b Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants