Implement server type/version for PDO_ODBC getAttr #6935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As an example using the IBM Db2i ODBC driver: PDO::ATTR_SERVER_INFO: DB2/400 SQL PDO::ATTR_SERVER_VERSION: 07.02.0015 Sidebar (probably for @cmb69): Other attribute types seem to be sporadically implemented across PDO drivers, so I haven't implemented them yet. For example, about half of the drivers implement the autocommit attribute by just returning it from the PDO state, others don't. Makes me curious what should be missing. After this patch, I do know autocommit, connection status, prefetch, and timeout are missing gettings, and some of that probably doesn't map to ODBC anyways. (Setters I haven't even gotten into.)
cmb69
reviewed
May 4, 2021
|
@NattyNarwhal Thanks for addressing @cmb69's feedback. 👍🏻 |
|
@ramsey, I think this should have an entry in UPGRADING (so it doesn't get overlooked for the migration guide). Could you please add it? An entry in NEWS might be appropriate, too. |
|
I'll get that added. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example using the IBM Db2i ODBC driver:
Sidebar (probably for @cmb69):
Other attribute types seem to be sporadically implemented across PDO drivers, so I haven't implemented them yet. For example, about half of the drivers implement the autocommit attribute by just returning it from the PDO state, others don't. Makes me curious what should be missing. After this patch, I do know autocommit, connection status, prefetch, and timeout are missing gettings, and some of that probably doesn't map to ODBC anyways. (Setters I haven't even gotten into.)