Skip to content

Correct the argument names for ext/sodium functions #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Correct the argument names for ext/sodium functions #6969

wants to merge 1 commit into from

Conversation

paragonie-security
Copy link
Contributor

No description provided.

@paragonie-security paragonie-security mentioned this pull request May 10, 2021
Closed
nikic
nikic approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, I'll merge into PHP-8.0.

@nikic nikic closed this in 0c57ebb May 10, 2021
@staabm
Copy link
Contributor

staabm commented May 10, 2021

Looks right, I'll merge into PHP-8.0.

wont this break BC for php8.0 with named arguments?

@paragonie-security paragonie-security deleted the sodium-fix-param-names branch May 10, 2021 19:26
@paragonie-security
Copy link
Contributor Author

Yes, that is a risk. However, we don't see any evidence of anyone using this PHP feature with ext/sodium specifically, so the risk is probably very small.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paragonie-security @staabm @nikic