Add zend_getpagesize() and reuse it in accelerator and fiber #7057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
May 27, 2021
| GetSystemInfo(&system_info); | ||
| page_size = system_info.dwPageSize; | ||
| # else | ||
| page_size = getpagesize(); |
There was a problem hiding this comment.
It looks like we're unconditionally using getpagesize() here. Why does the new code limit its use to only FreeBSD?
There was a problem hiding this comment.
Linux manual recommends using sysconf(_SC_PAGESIZE) instead of getpagesize() for portability.
The code is referenced from https://github.com/jemalloc/jemalloc/blob/master/src/pages.c#L417
The comment shows the reason for it, it can avoid a useless syscall on FreeBSD.
nikic
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is referenced from https://github.com/jemalloc/jemalloc/blob/master/src/pages.c#L417 .
A small change, just for code reuse.